[wptrunner] Support testdriver.js in {ref,print-ref,crash}tests #48486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
5 times, most recently
from
41b2fb1 to
c4a6d69
Compare
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
3 times, most recently
from
7b80717 to
25d7265
Compare
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
2 times, most recently
from
a0230ef to
0efaa69
Compare
wpt-pr-bot
added
docs
infra
manifest
wptrunner
|
PTAL @WeizhongX @jgraham. Chrome and Safari pass the new |
jonathan-j-lee
added a commit
that referenced
this pull request
Dec 13, 2024
Relax the `TESTDRIVER-IN-UNSUPPORTED-TYPE` rule now that #48486 has landed. `wpt lint` still bans `testdriver.js` in manual tests, since there's no external WebDriver program to drive testdriver.
|
...so is it now ok to move some tests using this capability over to the repo? |
From pure WPT PRs, yes. From |
|
@mfreed7 |
|
Nice! Thanks for getting this landed. {I'll give it a try myself, here: https://crrev.com/c/6077774 } |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
See conversations at: web-platform-tests/rfcs#211 #13183 As of today, this can land: #48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
As of #48486, the WebDriver-based testdriver infrastructure now supports {ref,crash}tests. Revert most of https://crrev.com/c/5972758 to move the tests back. In Chromium CQ, moving the tests out of `wpt_internal/` also has the effect of running the tests with `headless_shell` + `chromedriver`, which passes these tests. Bug: None Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 14, 2024
As of web-platform-tests/wpt#48486, the WebDriver-based testdriver infrastructure now supports {ref,crash}tests. Revert most of https://crrev.com/c/5972758 to move the tests back. In Chromium CQ, moving the tests out of `wpt_internal/` also has the effect of running the tests with `headless_shell` + `chromedriver`, which passes these tests. Bug: None Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Reviewed-by: Mike Wasserman <[email protected]> Commit-Queue: Mike Wasserman <[email protected]> Auto-Submit: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396271}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
As of #48486, the WebDriver-based testdriver infrastructure now supports {ref,crash}tests. Revert most of https://crrev.com/c/5972758 to move the tests back. In Chromium CQ, moving the tests out of `wpt_internal/` also has the effect of running the tests with `headless_shell` + `chromedriver`, which passes these tests. Bug: None Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Reviewed-by: Mike Wasserman <[email protected]> Commit-Queue: Mike Wasserman <[email protected]> Auto-Submit: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396271}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
See conversations at: web-platform-tests/rfcs#211 #13183 As of today, this can land: #48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 14, 2024
See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
As of #48486, the WebDriver-based testdriver infrastructure now supports {ref,crash}tests. Revert most of https://crrev.com/c/5972758 to move the tests back. In Chromium CQ, moving the tests out of `wpt_internal/` also has the effect of running the tests with `headless_shell` + `chromedriver`, which passes these tests. Bug: None Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Reviewed-by: Mike Wasserman <[email protected]> Commit-Queue: Mike Wasserman <[email protected]> Auto-Submit: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396271}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
See conversations at: web-platform-tests/rfcs#211 #13183 As of today, this can land: #48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 18, 2024
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <[email protected]>
Commit-Queue: Mike Wasserman <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 18, 2024
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 19, 2024
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <[email protected]>
Commit-Queue: Mike Wasserman <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 19, 2024
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2025
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <mswchromium.org>
Commit-Queue: Mike Wasserman <mswchromium.org>
Auto-Submit: Jonathan Lee <jonathanjleegoogle.com>
Cr-Commit-Position: refs/heads/main{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
UltraBlame original commit: d40b2c8ff387c21e9289b92afdc86dcad1e4c426
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2025
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfchromium.org> Commit-Queue: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688 UltraBlame original commit: 31380657f025c9e677795d2107c4264f45cfc0a6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2025
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <mswchromium.org>
Commit-Queue: Mike Wasserman <mswchromium.org>
Auto-Submit: Jonathan Lee <jonathanjleegoogle.com>
Cr-Commit-Position: refs/heads/main{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
UltraBlame original commit: d40b2c8ff387c21e9289b92afdc86dcad1e4c426
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2025
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfchromium.org> Commit-Queue: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688 UltraBlame original commit: 31380657f025c9e677795d2107c4264f45cfc0a6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2025
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <mswchromium.org>
Commit-Queue: Mike Wasserman <mswchromium.org>
Auto-Submit: Jonathan Lee <jonathanjleegoogle.com>
Cr-Commit-Position: refs/heads/main{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
UltraBlame original commit: d40b2c8ff387c21e9289b92afdc86dcad1e4c426
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2025
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfchromium.org> Commit-Queue: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688 UltraBlame original commit: 31380657f025c9e677795d2107c4264f45cfc0a6
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 2, 2025
…sts that use testdriver, a=testonly
Automatic update from web-platform-tests
[wpt][fullscreen] Upstream {ref,crash}tests that use testdriver
As of web-platform-tests/wpt#48486, the
WebDriver-based testdriver infrastructure now supports {ref,crash}tests.
Revert most of https://crrev.com/c/5972758 to move the tests back. In
Chromium CQ, moving the tests out of `wpt_internal/` also has the effect
of running the tests with `headless_shell` + `chromedriver`, which
passes these tests.
Bug: None
Change-Id: I396053ab5a7ab2a27558fa1de71af614107a8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088404
Reviewed-by: Mike Wasserman <[email protected]>
Commit-Queue: Mike Wasserman <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1396271}
--
wpt-commits: 70e5fd98c0eed8d024c7743fb476386a36c8b8d0
wpt-pr: 49690
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 2, 2025
… tests out of wpt_internal, a=testonly Automatic update from web-platform-tests Move all customizable-<select> reference tests out of wpt_internal See conversations at: web-platform-tests/rfcs#211 web-platform-tests/wpt#13183 As of today, this can land: web-platform-tests/wpt#48486 See, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/6088404 Change-Id: I43ffb77f93f4fa28e7aaa65beea8780f52f87242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077774 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396273} -- wpt-commits: 2134b52a0ed40aeb768cd2c2856db9b4724527a7 wpt-pr: 49688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
wpt {manifest,run}changes proposed in web-platform-tests/rfcs#211.